Hi, OK, so could you decide here what's best? (since me and Michael disagree I guess a third pair of eyes is good, I'll be happy with any decision you take, but at least there's been two people thinking it was the best choice)
Thanks, Guido On Tue, Feb 19, 2013 at 3:18 PM, Iustin Pop <[email protected]> wrote: > On Tue, Feb 19, 2013 at 03:13:50PM +0100, Guido Trotter wrote: >> On Tue, Feb 19, 2013 at 3:08 PM, Michael Hanselmann <[email protected]> >> wrote: >> > 2013/2/15 Guido Trotter <[email protected]>: >> >>> + if translate is None: >> >>> + fn = _CompileHandlerPath >> >>> + else: >> >>> + fn = translate >> >> >> >> How about calling it translate_fn >> >> (or just translate, if you prefer). >> >> fn is very generic as a name. >> > >> > Ack, but it's used 43 times and makes lines much longer (almost an >> > additional 0.5 kB with a “translate_” prefix! :-)). It's a local >> > helper variable—can we keep “fn”? >> > >> >> Since when we code for source code space optimization? :) > > To be fair, shorter source code means that for humans (which have a > sorter attention span) the code is more readable. > > I don't know if that's the case here, just saying the there is an > advantage of shorter code (up to a point). > > iustin -- Guido Trotter Ganeti engineering Google Germany
