2013/2/25 Iustin Pop <[email protected]>: > On Mon, Feb 25, 2013 at 04:28:48PM +0100, Michael Hanselmann wrote: >> --- a/lib/cmdlib.py >> +++ b/lib/cmdlib.py >> @@ -9559,7 +9559,9 @@ def _WipeDisks(lu, instance, disks=None): >> @param lu: the logical unit on whose behalf we execute >> @type instance: L{objects.Instance} >> @param instance: the instance whose disks we should create >> - @return: the success of the wipe >> + @type disks: None or list of tuple of (number, L{objects.Disk}, number) >> + @param disks: Disk details; tuple contains disk index, disk object and the >> + start offset > > Does the function not return anything useful? (maybe you want to > keep/add @rtype: None).
Sorry for not mentioning this in the commit message: No, it doesn't contain a single “return” statement. Convention throughout the code is to not use @rtype/@return if there is no explicit return value. Michael
