On Tue, Mar 12, 2013 at 09:46:21AM +0100, Helga Velroyen wrote: > On Mon, Mar 11, 2013 at 4:23 PM, Iustin Pop <[email protected]> wrote: > > > This is not run automatically (although it could/should), but is very > > useful during development. > > > > Signed-off-by: Iustin Pop <[email protected]> > > --- > > devel/check-split-query | 70 > > +++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 70 insertions(+) > > create mode 100755 devel/check-split-query > > > > diff --git a/devel/check-split-query b/devel/check-split-query > > new file mode 100755 > > index 0000000..e0a6659 > > --- /dev/null > > +++ b/devel/check-split-query > > @@ -0,0 +1,70 @@ > > +#!/bin/bash > > + > > +# Copyright (C) 2013 Google Inc. > > +# > > +# This program is free software; you can redistribute it and/or modify > > +# it under the terms of the GNU General Public License as published by > > +# the Free Software Foundation; either version 2 of the License, or > > +# (at your option) any later version. > > +# > > +# This program is distributed in the hope that it will be useful, but > > +# WITHOUT ANY WARRANTY; without even the implied warranty of > > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > +# General Public License for more details. > > +# > > +# You should have received a copy of the GNU General Public License > > +# along with this program; if not, write to the Free Software > > +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA > > +# 02110-1301, USA. > > + > > +# Checks query equivalence between masterd and confd > > +# > > +# This is not (currently) run automatically during QA, but you can run > > +# it manually on a test cluster. It will force all queries known to be > > +# converted via both paths and check the difference, via both 'list' > > +# and 'list-fields'. For best results, it should be run on a non-empty > > +# cluster. > > +# > > +# Also note that this is not expected to show 100% perfect matches, > > +# since the JSON output differs slightly for complex data types > > +# (e.g. dictionaries with different sort order for keys, etc.). > > +# > > +# Current known delta: > > +# - all dicts, sort order > > +# - ctime is always defined in Haskell, as epoch 0 if missing > > > Nit: I think the comma is superfluous.
Ack, thanks. > > +# - external_reservations missing in gnt-network/Haskell > > > That's fixed with some other patch of this series, right? Oh right, forgot to remove it (wrote these comments before the patch series). Thanks! iustin
