On Tue, Mar 26, 2013 at 1:50 PM, Klaus Aehlig <aeh...@google.com> wrote:
>> > Add a simple walk trhough the intended use case of
>>
>> Typo here: through
>>
>> > gnt-instance modify --new-primary for the disk template
>> > file. The tested scenario is shuting down an instance,
>>
>> typo here: shutting
>
> Both typos fixed (see new commit message attached).
>
>> > + if instance.disk_template != constants.DT_FILE:
>> > + print qa_utils.FormatInfo("Test only supported for the file disk
>> > template")
>> > + return
>> > +
>>
>> Won't this only work only if the whole qa is set to be file based?
>
> It follows the current scheme that tests do nothing if they don't
> support the underlying disk template, i.e., nothing breaks for the other
> disk templates (the test is just ignored), but nothing is tested either
> unless instance-add-file is enabled.
>
>> Should we change the qa to have qa-ed disk templates as a list, with
>> most tests running on the first one listed, and any test which
>> supports only some template run if that template is enabled?
>
> That sounds like a good idea, but in my opinion this is independent
> enough to warrant a separate patch series.
>
ACK. LGTM then, and then let's see if the test already works in our
environment, or we should do more changes to enable it.
Thanks,
Guido
