Re: [PATCH master] Add script for building chroot

[Michele Tartara]

On Wed, Apr 3, 2013 at 10:12 AM, Klaus Aehlig <aeh...@google.com> wrote:

> > +
> > +#Install the base system
> > +debootstrap --arch amd64 squeeze $CHDIR
> > +
>
> For the record: here you're hard-coding archicteture and release; this
> will have to be changed in the future. But it is probably best addressed
> in a follow-up commit when we move on from squeeze amd64.
>

Ok.


>
> So, together with the interdiff in the other mail: LGTM.
>

I just noticed that rsync (needed for the ./devel/upload script) was
missing.
If you can confirm the following interdiff, I will push the already fixed
chroot builder:

diff --git a/devel/build_chroot b/devel/build_chroot
index 3a16881..0a17383 100755
--- a/devel/build_chroot
+++ b/devel/build_chroot
@@ -56,7 +56,7 @@ in_chroot -- \

 in_chroot -- \
   $APT_INSTALL python-setuptools build-essential python-dev sudo automake
git \
-               fakeroot vim locales
+               fakeroot vim rsync locales

 echo "en_US.UTF-8 UTF-8" >> $CHDIR/etc/locale.gen


Thanks,
Michele