On 3 April 2013 18:47, Klaus Aehlig <[email protected]> wrote: > On Wed, Apr 03, 2013 at 06:10:12PM +0200, Bernardo Dal Seno wrote: >> On 3 April 2013 17:16, Klaus Aehlig <[email protected]> wrote: >> > This list contains the disk templates suitable for moving >> > an instance by copying the files. A requirement is that >> > they're not accessed externally or shared between nodes; >> > in particular, sharedfile is not suitable. >> > >> > Signed-off-by: Klaus Aehlig <[email protected]> >> > --- >> > lib/constants.py | 7 +++++++ >> > 1 file changed, 7 insertions(+) >> > >> > diff --git a/lib/constants.py b/lib/constants.py >> > index 8dbcae5..e9e127e 100644 >> > --- a/lib/constants.py >> > +++ b/lib/constants.py >> > @@ -425,6 +425,13 @@ DTS_FILEBASED = compat.UniqueFrozenset([ >> > DT_SHARED_FILE, >> > ]) >> > >> > +# the set of disk templates that can be moved by copying >> > +# Note: these templates should imply the absence of external access >> >> This note is explained better in the commit message. Please integrate >> this comment (maybe by copying part of the commit message), as I'm >> afraid "absence of external access" is not clear enough (e.g., >> external to the cluster?). > > Interdiff > > diff --git a/lib/constants.py b/lib/constants.py > index e9e127e..0fa47de 100644 > --- a/lib/constants.py > +++ b/lib/constants.py > @@ -426,7 +426,8 @@ DTS_FILEBASED = compat.UniqueFrozenset([ > ]) > > # the set of disk templates that can be moved by copying > -# Note: these templates should imply the absence of external access > +# Note: a requirement is that they're not accessed externally or shared > between > +# nodes; in particular, sharedfile is not suitable. > DTS_COPYABLE = compat.UniqueFrozenset([ > DT_FILE, > DT_PLAIN, >
LGTM, thanks. Bernardo
