LGTM, thanks
On Wed, Apr 3, 2013 at 6:02 PM, Bernardo Dal Seno <[email protected]>wrote: > After changing the way gnt-xxx info print their output, > cli.FormatParameterDict() is not used anymore. > > Signed-off-by: Bernardo Dal Seno <[email protected]> > --- > lib/cli.py | 28 ---------------------------- > 1 file changed, 28 deletions(-) > > diff --git a/lib/cli.py b/lib/cli.py > index fea2c1d..1c4873e 100644 > --- a/lib/cli.py > +++ b/lib/cli.py > @@ -234,7 +234,6 @@ __all__ = [ > "ToStderr", "ToStdout", > "FormatError", > "FormatQueryResult", > - "FormatParameterDict", > "FormatParamsDictInfo", > "FormatPolicyInfo", > "PrintGenericInfo", > @@ -3592,33 +3591,6 @@ class JobExecutor(object): > return [row[1:3] for row in self.jobs] > > > -def FormatParameterDict(buf, param_dict, actual, level=1): > - """Formats a parameter dictionary. > - > - @type buf: L{StringIO} > - @param buf: the buffer into which to write > - @type param_dict: dict > - @param param_dict: the own parameters > - @type actual: dict > - @param actual: the current parameter set (including defaults) > - @param level: Level of indent > - > - """ > - indent = " " * level > - > - for key in sorted(actual): > - data = actual[key] > - buf.write("%s- %s:" % (indent, key)) > - > - if isinstance(data, dict) and data: > - buf.write("\n") > - FormatParameterDict(buf, param_dict.get(key, {}), data, > - level=level + 1) > - else: > - val = param_dict.get(key, "default (%s)" % data) > - buf.write(" %s\n" % val) > - > - > def FormatParamsDictInfo(param_dict, actual): > """Formats a parameter dictionary. > > -- > 1.8.1.3 > >
