LGTM, Could we also add some qa that would have caught this? Thanks,
Guido On 10 Apr 2013 10:44, "Michele Tartara" <[email protected]> wrote: > Trasforming the disk of an instance from DRBD to plain did not properly > update the iv_name of disks, leaving it to None. > > This commit modifies _ConvertDrbdToPlain to properly set the iv_name > variables. > > An analogous fix is not required in the opposite function, > _ConvertPlainToDrbd, because it uses _GenerateDiskTemplate, that already > takes care of doing that. > > Fixes Issue 403. > > Signed-off-by: Michele Tartara <[email protected]> > --- > lib/cmdlib.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/cmdlib.py b/lib/cmdlib.py > index 023084f..5ad1338 100644 > --- a/lib/cmdlib.py > +++ b/lib/cmdlib.py > @@ -14043,6 +14043,7 @@ class LUInstanceSetParams(LogicalUnit): > # update instance structure > instance.disks = new_disks > instance.disk_template = constants.DT_PLAIN > + _UpdateIvNames(0, instance.disks) > self.cfg.Update(instance, feedback_fn) > > # Release locks in case removing disks takes a while > -- > 1.7.10.4 > >
