LGTM, thanks
On Thu, Apr 11, 2013 at 7:57 AM, Michele Tartara <[email protected]>wrote: > Importing an instance, like JSON, automatically allows the names of all > its functions to be used. > > If one of this functions (namely showJSON) is imported separately, GHC 6 > is fine with that, but GHC 7 emits a warning (therefore, the compilation of > Ganeti fails because it requires no warnings). > > This patch fixes the build for GHC 7 and has no impact on GHC 6. > > Note that the same does not apply to the import of readJSON, because that > function is actually used in the same file, so it must be imported > separately. > > Signed-off-by: Michele Tartara <[email protected]> > --- > src/Ganeti/OpCodes.hs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/Ganeti/OpCodes.hs b/src/Ganeti/OpCodes.hs > index 66d6e79..080529b 100644 > --- a/src/Ganeti/OpCodes.hs > +++ b/src/Ganeti/OpCodes.hs > @@ -48,7 +48,7 @@ module Ganeti.OpCodes > ) where > > import Data.Maybe (fromMaybe) > -import Text.JSON (readJSON, showJSON, JSON, JSValue, makeObj) > +import Text.JSON (readJSON, JSON, JSValue, makeObj) > import qualified Text.JSON > > import Ganeti.THH > -- > 1.8.1.3 > >
