Ack, LGTM then, sorry :) Guido
On Thu, Apr 11, 2013 at 7:16 AM, Klaus Aehlig <[email protected]> wrote: > On Thu, Apr 11, 2013 at 06:31:32AM -0400, Guido Trotter wrote: >> On Thu, Apr 11, 2013 at 6:19 AM, Klaus Aehlig <[email protected]> wrote: >> > Instance policy on disks is specified on a per-disk basis. So extend >> > the instance description by the sizes of the individual disks and modify >> > the instance policy verification to correctly check individual disks. >> > >> > Signed-off-by: Klaus Aehlig <[email protected]> >> >> I'm a bit lost: does this even compile without 2/3 ? > > Yes. And all tests pass. > I just verified that, again, on a clean checkout wich just patch 1/3 applied. > > Did you notice the hunk > > @@ -171,6 +172,7 @@ create name_init mem_init dsk_init vcpus_init run_init > tags_init > , alias = name_init > , mem = mem_init > , dsk = dsk_init > + , disks = [dsk_init] > , vcpus = vcpus_init > , runSt = run_init > , pNode = pn > > which, in one line, shows the what incorrect assumption > hail is making at the moment? Implicitly, the assumption is, that > all disk space is consumed by a single huge disk. > > Patch 2/3 then fixes this by taking 'disks' as additional parameter > to the create function (thus changing a visible interface), while > patch 1/3 is has no observable effect when taking Ganeti.HTools.Instance > as a black box (but, of course, it fixes the internal structure of > that module). > > Klaus > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Katherine Stephens -- Guido Trotter Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Katherine Stephens Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
