On Mon, Apr 29, 2013 at 3:11 PM, Thomas Thrainer <[email protected]>wrote:
> A `buildbot try` revealed that I forgot to add the file to Makefile.am. > > So here's the interdiff: > > diff --git a/Makefile.am b/Makefile.am > index 0d308c0..aa61abb 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -1093,6 +1093,7 @@ TEST_FILES = \ > test/data/ovfdata/wrong_xml.ovf \ > test/data/proc_drbd8.txt \ > test/data/proc_drbd80-emptyline.txt \ > + test/data/proc_drbd80-emptyversion.txt \ > test/data/proc_drbd83.txt \ > test/data/proc_drbd83_sync.txt \ > test/data/proc_drbd83_sync_want.txt \ > > Thanks, > Thomas > > > On Mon, Apr 29, 2013 at 2:14 PM, Michele Tartara <[email protected]>wrote: > >> On Mon, Apr 29, 2013 at 1:51 PM, Thomas Thrainer <[email protected]>wrote: >> >>> The previous patch removed a (rather implicit) test for /proc/drbd not >>> containing a version line. This adds an explicit test for this case. >>> >>> Signed-off-by: Thomas Thrainer <[email protected]> >>> --- >>> test/data/proc_drbd80-emptyversion.txt | 9 +++++++++ >>> test/hs/Test/Ganeti/Block/Drbd/Parser.hs | 23 +++++++++++++++++++++++ >>> test/py/ganeti.block.bdev_unittest.py | 8 ++++++++ >>> 3 files changed, 40 insertions(+) >>> create mode 100644 test/data/proc_drbd80-emptyversion.txt >>> >>> >> LGTM, thanks. >> >> Michele >> > > > > -- > Thomas Thrainer | Software Engineer | [email protected] | > > Google Germany GmbH > Dienerstr. 12 > 80331 München > > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschäftsführer: Graham Law, Katherine Stephens > Thanks, I was just going to run it before pushing the patch set. LGTM. Michele
