LGTM, thanks
On Mon, Apr 29, 2013 at 4:28 PM, Klaus Aehlig <[email protected]> wrote: > So far, any successful query was only logged at debug level, thus leaving > no traces in the logs, unless debugging was enabled. Therefore, we add > a notes about successful completion at info level. Also, repeat a failed > request at WARN level, so that, even if debugging disabled, the request > is available together with the error message in the logs. > > Signed-off-by: Klaus Aehlig <[email protected]> > --- > src/Ganeti/Query/Server.hs | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/Ganeti/Query/Server.hs b/src/Ganeti/Query/Server.hs > index f4a9e78..76fcfd6 100644 > --- a/src/Ganeti/Query/Server.hs > +++ b/src/Ganeti/Query/Server.hs > @@ -175,7 +175,6 @@ handleCall _ op = > return . Bad $ > GenericError ("Luxi call '" ++ strOfOp op ++ "' not implemented") > > - > -- | Given a decoded luxi request, executes it and sends the luxi > -- response back to the client. > handleClientMsg :: Client -> ConfigReader -> LuxiOp -> IO Bool > @@ -186,11 +185,13 @@ handleClientMsg client creader args = do > (!status, !rval) <- > case call_result of > Bad err -> do > - logWarning $ "Failed to execute request: " ++ show err > + logWarning $ "Failed to execute request " ++ show args ++ ": " > + ++ show err > return (False, showJSON err) > Ok result -> do > -- only log the first 2,000 chars of the result > logDebug $ "Result (truncated): " ++ take 2000 (J.encode result) > + logInfo $ "Successfully handled " ++ strOfOp args > return (True, result) > sendMsg client $ buildResponse status rval > return True > -- > 1.8.2.1 > >
