Hi!
On Tue, Apr 30, 2013 at 9:08 AM, Guido Trotter <[email protected]> wrote: > On Mon, Apr 29, 2013 at 7:06 PM, Helga Velroyen <[email protected]> wrote: > > This patch extends the man page of the 'gnt-instance' command > > by describing the newly implemented hypervisor parameter > > 'vif_type'. > > > > Signed-off-by: Helga Velroyen <[email protected]> > > LGTM > > > --- > > man/gnt-instance.rst | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/man/gnt-instance.rst b/man/gnt-instance.rst > > index f65dd47..3a4fbf5 100644 > > --- a/man/gnt-instance.rst > > +++ b/man/gnt-instance.rst > > @@ -270,6 +270,16 @@ nic\_type > > - e1000 (KVM) > > - paravirtual (default for KVM) (HVM & KVM) > > > > +vif\_type > > + Valid for the Xen HVM hypervisor. > > + > > + This parameter specifies the vif type of the nic configuration > > + of the instance. Unsetting the value leads to no type being > specified > > + in the configuration. The possible options are: > > + > > + - ioemu (default for Xen HVM) > > You could even remove "for Xen HVM" here, since the hv parameter is > only valid for Xen HVM. > ok, I'm sending an interdif. > > > + - vif > > + > > disk\_type > > Valid for the Xen HVM and KVM hypervisors. > > > > Thanks, > > Guido > I also realized that it might be good to know that the parameter is only used if nic_type is not set, I added t his to the description: diff --git a/man/gnt-instance.rst b/man/gnt-instance.rst index 3a4fbf5..1960404 100644 --- a/man/gnt-instance.rst +++ b/man/gnt-instance.rst @@ -275,9 +275,10 @@ vif\_type This parameter specifies the vif type of the nic configuration of the instance. Unsetting the value leads to no type being specified - in the configuration. The possible options are: + in the configuration. Note that this parameter only takes effect when + the 'nic_type' is not set. The possible options are: - - ioemu (default for Xen HVM) + - ioemu - vif disk\_type Cheers, Helga
