On Mon, May 6, 2013 at 10:54 PM, Bernardo Dal Seno <[email protected]>wrote:
> On 6 May 2013 22:10, Helga Velroyen <[email protected]> wrote: > > This corrects the storage types design doc regarding the specification > > of the RPC call. > > > > Signed-off-by: Helga Velroyen <[email protected]> > > --- > > doc/design-storagetypes.rst | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/doc/design-storagetypes.rst b/doc/design-storagetypes.rst > > index 471c819..570eabf 100644 > > --- a/doc/design-storagetypes.rst > > +++ b/doc/design-storagetypes.rst > > @@ -160,15 +160,15 @@ RPC changes > > ----------- > > > > The noded RPC call that reports node storage space will be changed to > > -accept a list of <disktemplate>,<key> string tuples. For each of them, > it will > > +accept a list of <storage_type>,<key> string tuples. For each of them, > it will > > report the free amount of storage space found on storage <key> as known > > -by the requested disk template. Depending on the disk template, the key > would > > -be a volume group name, in case of lvm-based disk templates, a > directory name > > -for the file and shared file storage, and a rados pool name for rados > storage. > > +by the requested storage_type. Depending on the storage_type, the key > would > > +be a volume group name, in case of lvm, a directory name for the > file-based > > The comma after "name" shouldn't have been there. Please remove it, > while you are changing these lines. > > Wasn't it <storage_type>,<key>,[params] ? Thanks, Guido
