LGTM Thanks,
Guido On Fri, May 10, 2013 at 11:10 AM, Klaus Aehlig <[email protected]> wrote: > On Fri, May 10, 2013 at 09:52:00AM +0200, Guido Trotter wrote: > > On Fri, May 10, 2013 at 9:40 AM, Thomas Thrainer <[email protected] > >wrote: > > > > > LGTM, Thanks > > > > > > On Wed, May 8, 2013 at 9:22 PM, Klaus Aehlig <[email protected]> > wrote: > > > > > >> [..] > > >> > > >> ./test/hs/hroller --node-tags=blue --no-headers -t > > >> $TESTDATA_DIR/multiple-tags.data > > >> ->>>/node-01-00.,node-01-00.,node-01-00?/ > > >> +>>>/node-01-00.,node-01-00.,node-01-00./ > > >> > > > > > Do you need a "$" at the end (and perhaps a ^ at the beginning) to make > > sure that's the whole line? > > Yes, good idea. In this case, this really makes sense, as the cluster > contains more nodes than the ones selected for output. > > Interdiff. > > diff --git a/test/hs/shelltests/htools-hroller.test > b/test/hs/shelltests/htools-hroller.test > index 643d0d4..36cf412 100644 > --- a/test/hs/shelltests/htools-hroller.test > +++ b/test/hs/shelltests/htools-hroller.test > @@ -16,11 +16,11 @@ node-01-001 > >>>= 0 > > ./test/hs/hroller --node-tags=red --no-headers -t > $TESTDATA_DIR/multiple-tags.data > ->>>/node-01-00.,node-01-00.,node-01-001/ > +>>>/^node-01-00.,node-01-00.,node-01-001$/ > >>>= 0 > > ./test/hs/hroller --node-tags=blue --no-headers -t > $TESTDATA_DIR/multiple-tags.data > ->>>/node-01-00.,node-01-00.,node-01-00./ > +>>>/^node-01-00.,node-01-00.,node-01-00.$/ > >>>= 0 > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Katherine Stephens > -- Guido Trotter Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Katherine Stephens Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
