On Mon, May 13, 2013 at 10:06 AM, Klaus Aehlig <[email protected]> wrote:
> On Fri, May 10, 2013 at 02:57:24PM +0200, Michele Tartara wrote: > > Instead of building the report as part of the "Main" function, have it > > built by its own dedicated function, so that it will be able to export it > > directly to the monitoring daemon when needed. > > > > Signed-off-by: Michele Tartara <[email protected]> > > --- > > src/Ganeti/DataCollectors/InstStatus.hs | 23 +++++++++++++++-------- > > 1 file changed, 15 insertions(+), 8 deletions(-) > > > > diff --git a/src/Ganeti/DataCollectors/InstStatus.hs > b/src/Ganeti/DataCollectors/InstStatus.hs > > index f3a8c1c..ecde3a2 100644 > > --- a/src/Ganeti/DataCollectors/InstStatus.hs > > +++ b/src/Ganeti/DataCollectors/InstStatus.hs > > @@ -38,7 +38,7 @@ module Ganeti.DataCollectors.InstStatus > > import Control.Exception.Base > > import Data.Maybe > > import qualified Data.Map as Map > > -import Network.BSD (getHostName) > > +import Network.BSD > > In which way is this change of import related to the rest of this patch? > Or did I miss the additional function from that module that is now used. > > No you are right. This change is actually useless. In a previous version of the patch, I needed to use the HostName data type that is exported by Network.BSD, so I changed it. But in the version that I actually sent, that is not required anymore. I'll undo the change of this line before pushing. Thanks for pointing it out. > Rest LGTM. Thanks. > Thanks, Michele
