On Tue, May 14, 2013 at 5:45 PM, Pulkit Singhal <[email protected]>wrote:
Hi, Hi everyone, > > I've applied to Ganeti as part of Google Summer of Code. As per Guido's > suggestion, I'm working on fixing the Issue > 235<https://code.google.com/p/ganeti/issues/detail?id=235>, > allow non-standard ssh ports. I'm attaching the patch which allows > non-standard port for gnt-node add command. I couldn't get the code from > the master repo to compile, hence I developed and tested it on 2.7.0~rc1. > The relevant code is same in both of them, hence the patch should be > compatible. > > It would be best to develop on master. What problems are you having getting the code to compile? (it should definitely do so, as we do continuous integration, and we make sure it always builds). Are you having dependency problems? or some other kind? > Changes include > > - Implemented '--ssh-port <port>' option in gnt-node > - Included an additional option for port in bootstrap.py's - > .RunNodeSetupCmd, _SetupSSH; ssh.py's BuildCmd and _BuildSshOptions. > - Modified SshRunner._BuildSshOptions to include "-p <port>" option > for ssh command. > > It would be best to split such patches in a small series, introducing independent parts one by one. This makes it easier to review them. It's also good to prepare the patches via git format-patch and send them out via git send-email. > I'm having a little trouble performing the complete "node add" operation > though, irrespective of this patch. I get the following error when I issue > "gnt-node add <nodename>" > > 2013-05-14 12:34:46,939: Unhandled Ganeti error: Given cluster certificate > does not match local key > Failure: command execution error: > Command 'ssh -oEscapeChar=none -oHashKnownHosts=no > -oGlobalKnownHostsFile=/var/lib/ganeti/known_hosts > -oUserKnownHostsFile=/dev/null -oCheckHostIp=no -p1111 > -oStrictHostKeyChecking=ask > [email protected]/usr/local/lib/ganeti/prepare-node-join' failed: exited > with exit code 1 > > I kindly request your suggestions and feedback. > Can you double check on the node itself if there are any logs that say more? Which distribution do you use? Does gnt-cluster verify return any error? Did gnt-cluster init? Thanks a lot, Guido > Thanks, > > Pulkit Singhal > -- Guido Trotter Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Katherine Stephens Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
