On Tue, May 14, 2013 at 7:52 PM, Bernardo Dal Seno <[email protected]>wrote:
> On 14 May 2013 15:52, Thomas Thrainer <[email protected]> wrote: > > LUTags* and their base class, TagsLU, are extracted to tags.py. An > > additional shared function, _ShareAll, is extracted to common.py for > > shared usage. > > Shouldn't the move of _ShareAll be part of the previous patch? > I extracted helper functions only in the moment when they were used by at least two files. _ShareAll was previously only used in instance.py, but this patch extracted tags.py which also requires it. That's why it's in this patch. BTW, this pattern repeats itself over the course of the whole patch series. There are a lot more functions extracted only in the moment another extraction required it. > > > > > Signed-off-by: Thomas Thrainer <[email protected]> > > --- > > Makefile.am | 3 +- > > lib/cmdlib/__init__.py | 187 +------------------------------------------ > > lib/cmdlib/common.py | 8 ++ > > lib/cmdlib/tags.py | 210 > +++++++++++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 222 insertions(+), 186 deletions(-) > > create mode 100644 lib/cmdlib/tags.py > > Rest LGTM, thanks. > > Bernardo > -- Thomas Thrainer | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Katherine Stephens
