On Wed, May 15, 2013 at 03:39:08PM +0200, Helga Velroyen wrote:
> This patch adds generators for Disk instances to the Haskell
> test code. It uses somewhat more reasonable generators to
> fill the fields instead of just arbitrary values.
> 'genDiskWithChildren' is a generator that generates a disk
> with a specified number of disk children. To avoid shooting
> ourselves in the foot we do not generate further (grand)
> child disks for the child disks. 'genDisk' calls
> 'genDiskWithChildren' by requesting three children as a
> resonable default.
> 
> Signed-off-by: Helga Velroyen <[email protected]>
> ---
>  test/hs/Test/Ganeti/Objects.hs | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)

LGTM. Thanks.

-- 
Klaus Aehlig
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Graham Law, Katherine Stephens

Reply via email to