On 16 May 2013 17:44, Bernardo Dal Seno <[email protected]> wrote: > On 16 May 2013 10:23, Thomas Thrainer <[email protected]> wrote: >> All LUInstance* classes are extracted to instance.py. Common functions >> are moved to common.py if used by non-node logical units as well. > > s/non-node/non-instance/ > >> Additionally, helper functions which are only used by LUBackup* and >> LUInstance* are moved to instance_utils.py. >> >> Signed-off-by: Thomas Thrainer <[email protected]> >> --- >> Makefile.am | 2 + >> lib/cmdlib/__init__.py | 8098 >> +------------------------------------ >> lib/cmdlib/common.py | 20 +- >> lib/cmdlib/instance.py | 7663 +++++++++++++++++++++++++++++++++++ >> lib/cmdlib/instance_utils.py | 472 +++ >> lib/cmdlib/node.py | 194 +- >> test/py/ganeti.cmdlib_unittest.py | 177 +- >> test/py/ganeti.config_unittest.py | 10 +- >> 8 files changed, 8360 insertions(+), 8276 deletions(-) >> create mode 100644 lib/cmdlib/instance.py >> create mode 100644 lib/cmdlib/instance_utils.py
Also, _ComputeIPolicyNodeViolation disappears in this patch only to reappear in the "Extract storage related functionality" one. It's better to conserve it during the intermediate changes. Bernardo
