On 16 May 2013 10:23, Thomas Thrainer <[email protected]> wrote:
> Split instance.py further by extracting migration related logical units
> and functions to instance_migration.py.

Again, please add "cmdlib" to the title.

>
> Signed-off-by: Thomas Thrainer <[email protected]>
> ---
>  Makefile.am                      |   1 +
>  lib/cmdlib/__init__.py           |   5 +-
>  lib/cmdlib/instance.py           | 962 
> +--------------------------------------
>  lib/cmdlib/instance_migration.py | 928 +++++++++++++++++++++++++++++++++++++
>  lib/cmdlib/instance_utils.py     |  65 +++
>  5 files changed, 1002 insertions(+), 959 deletions(-)
>  create mode 100644 lib/cmdlib/instance_migration.py
>
> diff --git a/Makefile.am b/Makefile.am
> index 64306df..9e0a6f4 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -316,6 +316,7 @@ cmdlib_PYTHON = \
>         lib/cmdlib/node.py \
>         lib/cmdlib/instance.py \
>         lib/cmdlib/instance_storage.py \
> +       lib/cmdlib/instance_migration.py \

This is not in the right order.

Rest LGTM, thanks.
Bernardo

Reply via email to