On 16 May 2013 10:23, Thomas Thrainer <[email protected]> wrote: > Split instance.py further by extracting operations > (start/stop/reboot/etc.) related logical units and functions to > instance_operation.py.
Operations, both here and in the title, seems too generic to be useful. Maybe instance operations? If possible, also mention "cmdlib". > diff --git a/Makefile.am b/Makefile.am > index 9e0a6f4..4c8b3ac 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -317,6 +317,7 @@ cmdlib_PYTHON = \ > lib/cmdlib/instance.py \ > lib/cmdlib/instance_storage.py \ > lib/cmdlib/instance_migration.py \ > + lib/cmdlib/instance_operation.py \ Hopefully this comes in the correct order after rebasing. > diff --git a/lib/cmdlib/instance_operation.py > b/lib/cmdlib/instance_operation.py > new file mode 100644 > index 0000000..cdc628e > --- /dev/null > +++ b/lib/cmdlib/instance_operation.py > @@ -0,0 +1,497 @@ > +# > +# > + > +# Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Google Inc. > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 2 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, but > +# WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > +# General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program; if not, write to the Free Software > +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA > +# 02110-1301, USA. > + > + > +"""Logical units dealing with operation of instance (start/stop/...).""" s/operation/operations/ and s/instance/instances/, or s/operation of instance/instance operations/, or... Rest LGTM, thanks. Bernardo
