Hi, I just pushed the patch to master. A couple of hints for the next submissions though: * Use `git commit --signoff` in order to include the Signed-off-by header in the commit. * Don't leave any trailing whitespace in any of your files. * Don't use tabs. * Please include a meaningful commit message, not just a title.
I also added a link to your design doc to design-draft.rst. Thanks, Thomas On Sat, Jul 13, 2013 at 1:45 PM, Izhar ul Hassan <[email protected]> wrote: > Hi, > > On Jul 13, 2013, at 10:10 AM, Guido Trotter <[email protected]> wrote: > > > On Fri, Jul 12, 2013 at 1:34 PM, <[email protected]> wrote: > >> From: Izhar <[email protected]> > >> > > > > LGTM (will push later next week). > > Thanks a lot for your support and patience :) > > I have finished the task to make mem_path changeable only at cluster and > node > group level and not at instance level. Before sending the patches, should > I perform > some testing? Could you please point me to some resources regarding the > testing > procedures. > > /Izhar -- Thomas Thrainer | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
