On Wed, Jul 31, 2013 at 03:25:36PM +0200, Guido Trotter wrote: > On Wed, Jul 31, 2013 at 12:55:04PM +0200, Jose A. Lopes wrote: > > From: "Jose A. Lopes" <[email protected]> > > > > Fix detection of default values for the opcodes. Fix spacing between > > opcode definitions. > > - Bullet points as bullet points. > - You forgot the "Fix spacing between opcode definitions" in a previous patch > - Can you explain why before it was just ht.NoDefault and now it has to be > "None" too?
The opcodes.py that existed before the Haskell to Python generation was completely inconsistent: sometimes it used None, sometimes it used ht.NoDefault. I made everything consistent by using None. However, there are still some traces of code that test for both. There is also some cryptic code that I couldn't decypher: I couldn't understand what it was trying to do. And because of that I couldn't fix it. This seems to be a deeper problems that spans several Python modules. > > Thanks, > > Guido >
