On Mon, Aug 19, 2013 at 9:55 AM, Thomas Thrainer <[email protected]>wrote:

> This LU (incorrectly) used the node name for locking. This patch
> corrects this error.
>
> Signed-off-by: Thomas Thrainer <[email protected]>
> ---
>  lib/cmdlib/instance.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/cmdlib/instance.py b/lib/cmdlib/instance.py
> index 3d3e90a..529a492 100644
> --- a/lib/cmdlib/instance.py
> +++ b/lib/cmdlib/instance.py
> @@ -1639,7 +1639,7 @@ class LUInstanceMove(LogicalUnit):
>      (self.op.target_node_uuid, self.op.target_node) = \
>        ExpandNodeUuidAndName(self.cfg, self.op.target_node_uuid,
>                              self.op.target_node)
> -    self.needed_locks[locking.LEVEL_NODE] = [self.op.target_node]
> +    self.needed_locks[locking.LEVEL_NODE] = [self.op.target_node_uuid]
>      self.needed_locks[locking.LEVEL_NODE_RES] = []
>      self.recalculate_locks[locking.LEVEL_NODE] = constants.LOCKS_APPEND
>
> --
> 1.8.3
>
>
LGTM, thanks.

Michele

-- 
Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Reply via email to