On Mon, Aug 26, 2013 at 10:22 AM, Jose A. Lopes <[email protected]>wrote:
> > > -def _CheckOutputFields(static, dynamic, selected):
> > > +def _CheckOutputFields(fields, selected):
> > > """Checks whether all selected fields are valid.
> > >
> > > - @type static: L{utils.FieldSet}
> > > - @param static: static fields set
> > > - @type dynamic: L{utils.FieldSet}
> > > - @param dynamic: dynamic fields set
> > > + @type fields: L{utils.FieldSet}
> > > + @param fields: fields set
> > >
> >
> > Please document the 'selected' parameter here as well.
>
> Will do.
>
> > > def CheckArguments(self):
> > > - _CheckOutputFields(static=self._FIELDS_STATIC,
> > > - dynamic=self._FIELDS_DYNAMIC,
> > > - selected=self.op.output_fields)
> > > + _CheckOutputFields(utils.FieldSet("node", "phys", "vg", "name",
> > > "size",
> > > + "instance"),
> > > + self.op.output_fields)
> > >
> >
> > Could we use constants here as well?
>
> Yes. I will submit it in another patch after committing this patch
> series. Sounds good with you ?
>
Yeah, sure!
LGTM with the documented param above then.
>
> Jose
>
--
Thomas Thrainer | Software Engineer | [email protected] |
Google Germany GmbH
Dienerstr. 12
80331 München
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores
