On Mon, Sep 9, 2013 at 6:25 PM, Jose A. Lopes <[email protected]> wrote:
> On Mon, Sep 09, 2013 at 06:16:29PM +0200, Michele Tartara wrote: > > On Fri, Aug 30, 2013 at 10:06 AM, Jose A. Lopes <[email protected] > >wrote: > > > > > In "lib/cmdlib/node.py", in lines 1315-1316, 1354, and 1359-1370, > > > replace string literals with constants. > > > > > > > Usually we keep the title of the patch "clean", and write "Fixes issue > > 558." as the last line of the description. > > What does "clean" title mean ? I don't write anything ? > No. Just leave: "Replace literals with constants" there, and put the reference to Issue 558 as the last line of the description. Sorry for not being clear. Cheers, Michele -- Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
