In this patch, if you remember, I had moved some Haskell types from 'Ganeti.Runtime' to 'Ganeti.BasicTypes'. This was part of the change I was introducing to flip the dependency between Haskell types and constants or, in other words, for Haskell constants to take their values from the Haskell types.
However, I have found a way to achieve this while at the same time preserving the types in 'Ganeti.Runtime', that is without having to move them to 'Ganeti.BasicTypes'. Therefore, I am going to reply to this thread with 2 new patches. The first patch will become patch number 2 in the patch series and it is a new patch. This patch updates 'Ganeti.Path' imports thus eliminating the circularity problems that I was facing before. And the second patch, which is patch number 3 in the patch series, is the old patch number 2, with the difference that the code is no longer being moved. On Fri, Sep 13, 2013 at 02:31:22PM +0200, Klaus Aehlig wrote: > > I moved this code from 'Ganeti.Runtime' to 'Ganeti.ConstantUtils' and > > I didn't really look at the instances because I didn't want to move > > code and change it at the same time, as it makes reviewing more > > difficult. > > OK then. LGTM > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores -- Jose Antonio Lopes Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
