Given that the master is (probably) fixed, this can go back to
reviewing.

On Thu, Sep 19, 2013 at 10:33:02AM +0200, Jose A. Lopes wrote:
> Add constants defined by the Haskell types in 'Ganeti.Objects', but
> first move these constants from 'Ganeti.Object' to 'Ganeti.Types'.
> 
> * move several Haskell data types from 'Ganeti.Objects' to
>   'Ganeti.Types' in order to be able to generate constants from them
>   without entering a circular dependency problem
> 
> * add the constants from the data types above
> 
> * update the Python references for those constants
> 
> Jose A. Lopes (3):
>   Move data types from 'Objects' to 'Types'
>   Hs2Py constants: add constants from types
>   Hs2Py constants: update Python references
> 
>  lib/constants.py                             | 42 +++++++-----------
>  src/Ganeti/DataCollectors/InstStatusTypes.hs |  1 -
>  src/Ganeti/HsConstants.hs                    | 62 +++++++++++++++++++++++---
>  src/Ganeti/Objects.hs                        | 60 +------------------------
>  src/Ganeti/Query/Common.hs                   |  1 +
>  src/Ganeti/Types.hs                          | 65 
> ++++++++++++++++++++++++++++
>  6 files changed, 139 insertions(+), 92 deletions(-)
> 
> -- 
> 1.8.4
> 

-- 
Jose Antonio Lopes
Ganeti Engineering
Google Germany GmbH
Dienerstr. 12, 80331, München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores
Steuernummer: 48/725/00206
Umsatzsteueridentifikationsnummer: DE813741370

Reply via email to