LGTM, thanks
On Wed, Sep 25, 2013 at 10:50 AM, Michele Tartara <[email protected]>wrote: > On Wed, Sep 25, 2013 at 10:41 AM, Michele Tartara <[email protected]>wrote: > >> Linting is now verified against the lint tools version numbers as listed >> in this >> patch. >> >> These version are corresponding to the ones that can be found in the >> repositories of Ubuntu 13.04. >> >> Signed-off-by: Michele Tartara <[email protected]> >> --- >> devel/build_chroot | 12 ++++++------ >> doc/devnotes.rst | 16 ++++++++-------- >> 2 files changed, 14 insertions(+), 14 deletions(-) >> >> diff --git a/devel/build_chroot b/devel/build_chroot >> index 7f53bc9..a462f8d 100755 >> --- a/devel/build_chroot >> +++ b/devel/build_chroot >> @@ -147,15 +147,15 @@ in_chroot -- \ >> >> in_chroot -- \ >> easy_install \ >> - logilab-astng==0.20.1 \ >> - logilab-common==0.50.3 \ >> + logilab-astng==0.24.1 \ >> + logilab-common==0.58.3 \ >> mock==1.0.1 \ >> - pylint==0.25.1 >> + pylint==0.26.0 >> >> in_chroot -- \ >> easy_install \ >> sphinx==1.1.3 \ >> - pep8==1.2 \ >> + pep8==1.3.3 \ >> coverage==3.4 \ >> bitarray==0.8.0 >> >> @@ -184,7 +184,7 @@ in_chroot -- \ >> cabal install --global \ >> hunit==1.2.5.2 \ >> happy==1.18.10 \ >> - hlint==1.8.34 \ >> + hlint==1.8.43 \ >> hscolour==1.20.3 \ >> temporary==1.1.2.3 \ >> test-framework==0.6.1 \ >> @@ -226,7 +226,7 @@ in_chroot -- \ >> >> #Python development tools >> in_chroot -- \ >> - $APT_INSTALL pandoc python-epydoc >> + $APT_INSTALL python-epydoc >> >> #Tools for creating debian packages >> in_chroot -- \ >> diff --git a/doc/devnotes.rst b/doc/devnotes.rst >> index 1a12ac9..80fc94c 100644 >> --- a/doc/devnotes.rst >> +++ b/doc/devnotes.rst >> @@ -31,13 +31,13 @@ Note that for pylint, at the current moment the >> following versions >> must be used:: >> >> $ pylint --version >> - pylint 0.25.1, >> - astng 0.23.1, common 0.58.0 >> + pylint 0.26.0, >> + astng 0.24.1, common 0.58.3 >> >> The same with pep8, other versions may give you errors:: >> >> $ pep8 --version >> - 1.2 >> + 1.3.3 >> >> Both these versions are the ones shipped with Debian Wheezy. >> >> @@ -51,10 +51,10 @@ Installation of all dependencies listed here:: >> $ apt-get install python-yaml python-mock >> $ cd / && sudo easy_install \ >> sphinx \ >> - logilab-astng==0.23.1 \ >> - logilab-common==0.58.0 \ >> - pylint==0.25.1 \ >> - pep8==1.2 \ >> + logilab-astng==0.24.1 \ >> + logilab-common==0.58.3 \ >> + pylint==0.26.0 \ >> + pep8==1.3.3 \ >> coverage >> >> For Haskell development, again all things from the quick install >> @@ -66,7 +66,7 @@ document, plus: >> used for documentation (it's source-code pretty-printing) >> - `hlint <http://community.haskell.org/~ndm/hlint/>`_, a source code >> linter (equivalent to pylint for Python), recommended version 1.8 or >> - above (tested with 1.8.15) >> + above (tested with 1.8.43) >> - the `QuickCheck <http://hackage.haskell.org/package/QuickCheck>`_ >> library, version 2.x >> - the `HUnit <http://hunit.sourceforge.net/>`_ library (tested with >> -- >> 1.7.10.4 >> >> > I'd like to add the following interdiff: > diff --git a/doc/devnotes.rst b/doc/devnotes.rst > index 80fc94c..98b8d23 100644 > --- a/doc/devnotes.rst > +++ b/doc/devnotes.rst > @@ -39,7 +39,7 @@ The same with pep8, other versions may give you errors:: > $ pep8 --version > 1.3.3 > > -Both these versions are the ones shipped with Debian Wheezy. > +Both these versions are the ones shipped with Ubuntu 13.04. > > To generate unittest coverage reports (``make coverage``), `coverage > <http://pypi.python.org/pypi/coverage>`_ needs to be installed. > > > > Thanks, > Michele > -- > Google Germany GmbH > Dienerstr. 12 > 80331 München > > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschäftsführer: Graham Law, Christine Elizabeth Flores > -- -- Helga Velroyen | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
