On Fri, Sep 27, 2013 at 12:01 PM, Spyros Trigazis <[email protected]>wrote:
> Hello team, > > I'm resending a patch series which exports CPUload data > provided by MonDs to HTools to be used in cluster scoring > computation. The data are available to HTools over network > or a mock file (mainly for testing purposes). > > Spyros > > root@node1:ganeti-spyros# git shortlog f56ab6d..HEAD > Spyros Trigazis (6): > Update hail, hbal and htools man-pages > Add MonD's latest API Version in lib/constants.py > Fetch data from MonD to HTools > Implement readJSON functions for DC Types > Import MonD data from file > Add test for mond-data mock file > > root@node1:ganeti-spyros# git diff --stat f56ab6d..HEAD > Makefile.am | 1 + > lib/constants.py | 3 ++ > man/hail.rst | 23 +++++++++++++++ > man/hbal.rst | 28 +++++++++++++++- > man/htools.rst | 19 ++++++++++++ > src/Ganeti/DataCollectors/Types.hs | 40 > ++++++++++++++++++++++---- > src/Ganeti/HTools/CLI.hs | 21 ++++++++++++++ > src/Ganeti/HTools/ExtLoader.hs | 177 +++++++++++++++-- > src/Ganeti/HTools/Program/Hail.hs | 12 ++++++-- > src/Ganeti/HTools/Program/Hbal.hs | 2 ++ > src/Ganeti/HTools/Program/Hinfo.hs | 3 ++ > src/Ganeti/Monitoring/Server.hs | 2 +- > test/data/mond-data.txt | 1 + > test/hs/Test/Ganeti/HTools/ExtLoader.hs | 111 ++++++++++++++++ > test/hs/Test/Ganeti/Hypervisor/Xen/XmParser.hs | 1 + > 15 files changed, 430 insertions(+), 14 deletions(-) > > Quick question related to the patch set as a whole. This introduces a way for hbal and hail to use CPU load average information from MonD to compute a good positioning for instances. But, while hbal is usually executed manually on it's own, so one can pass the --mond parameter, the same doesn't happen for hail, which is usually executed by masterd, therefore, as of the current state of the codebase, it will never receive that parameter, and it won't use mond data at all. Could you add a way to specify that mond should be used by masterd when invoking hail? Thanks, Michele -- Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
