+list (sorry, my bad...) LGTM, could you please resent the patch as a whole?
Cheers, Thomas On Wed, Oct 2, 2013 at 9:52 AM, Santi Raffa <[email protected]> wrote: > Second interdiff: > > diff --git a/lib/hypervisor/hv_xen.py b/lib/hypervisor/hv_xen.py > index 929a04e..d5dd431 100644 > --- a/lib/hypervisor/hv_xen.py > +++ b/lib/hypervisor/hv_xen.py > @@ -313,9 +313,10 @@ def _QuoteCpuidField(data): > > @param data: Either type of parameter. > @return: The quoted version thereof. > + > """ > > - return data if "[" in data else "'%s'" % data > + return data if "host" in data else "'%s'" % data > > > class XenHypervisor(hv_base.BaseHypervisor): > diff --git a/man/gnt-instance.rst b/man/gnt-instance.rst > index c7e8b54..89889fc 100644 > --- a/man/gnt-instance.rst > +++ b/man/gnt-instance.rst > @@ -731,16 +731,15 @@ soundhw > cpuid > Valid for the XEN hypervisor. > > - Modify the values returned by CPUID instructions run within instances. > + Modify the values returned by CPUID_ instructions run within > instances. > > This allows you to enable migration between nodes with different CPU > attributes like cores, threads, hyperthreading or SS4 support by > hiding > the extra features where needed. > > - See the XEN documentation for syntax and more information. Wikipedia > - also has a helpful article on the topic: > + See the XEN documentation for syntax and more information. > > - http://en.wikipedia.org/wiki/CPUID > +.. _CPUID: http://en.wikipedia.org/wiki/CPUID > > usb\_devices > Valid for the KVM hypervisor. > > -- > Raffa Santi > Google Germany GmbH > Dienerstr. 12 > 80331 München > > > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschäftsführer: Graham Law, Christine Elizabeth Flores > -- Thomas Thrainer | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
