LGTM.

Thanks,
Jose

On Wed, Oct 02, 2013 at 02:33:02PM +0200, Klaus Aehlig wrote:
> Conceptionally, the versions of the program, the protocols, and the
> configuration are three different things, even though, currently there
> is a tight coupling. So export the version as well, as the upgrades
> are designed to make decisions based on the version.
> 
> Signed-off-by: Klaus Aehlig <[email protected]>
> ---
>  lib/constants.py          | 4 ++++
>  src/Ganeti/HsConstants.hs | 9 +++++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/lib/constants.py b/lib/constants.py
> index 6e79f85..71e1278 100644
> --- a/lib/constants.py
> +++ b/lib/constants.py
> @@ -44,6 +44,10 @@ VCS_VERSION = _vcsversion.VCS_VERSION
>  EXPORT_VERSION = 0
>  RAPI_VERSION = 2
>  
> +VERSION_MAJOR = _constants.VERSION_MAJOR
> +VERSION_MINOR = _constants.VERSION_MINOR
> +VERSION_REVISION = _constants.VERSION_REVISION
> +
>  CONFIG_MAJOR = _constants.CONFIG_MAJOR
>  CONFIG_MINOR = _constants.CONFIG_MINOR
>  CONFIG_REVISION = _constants.CONFIG_REVISION
> diff --git a/src/Ganeti/HsConstants.hs b/src/Ganeti/HsConstants.hs
> index fd56b27..1985d71 100644
> --- a/src/Ganeti/HsConstants.hs
> +++ b/src/Ganeti/HsConstants.hs
> @@ -119,6 +119,15 @@ gntScripts = AutoConf.gntScripts
>  releaseVersion :: String
>  releaseVersion = AutoConf.packageVersion
>  
> +versionMajor :: Int
> +versionMajor = AutoConf.versionMajor
> +
> +versionMinor :: Int
> +versionMinor = AutoConf.versionMinor
> +
> +versionRevision :: Int
> +versionRevision = AutoConf.versionRevision
> +
>  configMajor :: Int
>  configMajor = AutoConf.versionMajor
>  
> -- 
> 1.8.4
> 

-- 
Jose Antonio Lopes
Ganeti Engineering
Google Germany GmbH
Dienerstr. 12, 80331, München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores
Steuernummer: 48/725/00206
Umsatzsteueridentifikationsnummer: DE813741370

Reply via email to