On Fri, Oct 04, 2013 at 12:44:10PM +0200, Klaus Aehlig wrote: > > In the commit message, don't you need a description in order for the > > patch to be pushed ? Or you can simply have the title in the commit > > message ? > > Normally, you need a commit message, not just the summary line. > However, there is an exeption for small patches (I think "small" > is defined as less than 5 lines); for small patches, the summary > line is enough, if it sufficiently describes the change (the latter > is, of course, not verified automatically). > > > On Wed, Oct 02, 2013 at 02:33:03PM +0200, Klaus Aehlig wrote: > > > Signed-off-by: Klaus Aehlig <[email protected]> > > > --- > > > lib/pathutils.py | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/lib/pathutils.py b/lib/pathutils.py > > > index 0c1202f..d95279b 100644 > > > --- a/lib/pathutils.py > > > +++ b/lib/pathutils.py > > > @@ -41,6 +41,7 @@ SSH_CONFIG_DIR = _constants.SSH_CONFIG_DIR > > > XEN_CONFIG_DIR = vcluster.AddNodePrefix(_constants.XEN_CONFIG_DIR) > > > SYSCONFDIR = vcluster.AddNodePrefix(_constants.SYSCONFDIR) > > > TOOLSDIR = _constants.TOOLSDIR > > > +PKGLIBDIR = _constants.PKGLIBDIR > > > > This constant is already available in 'lib/pathutils.py'. Either use > > the one in 'lib/pathutils.py' or add this one here and update the > > references to the other one. > > I don't think, I understand this comment. The file I'm changing _is_ > lib/pathutils.py
Sorry, my mistake. LGTM Thanks, Jose > > Klaus > > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores -- Jose Antonio Lopes Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
