LGTM on this interdiff. Thanks, Jose
On Fri, Oct 04, 2013 at 01:18:56PM +0200, Klaus Aehlig wrote: > On Wed, Oct 02, 2013 at 02:33:07PM +0200, Klaus Aehlig wrote: > > This command will coordinate the switching to a new > > Ganeti version across the cluster. This has become > > possible by the new layout that allows several Ganeti > > version to be present at the same time. > > > > Signed-off-by: Klaus Aehlig <[email protected]> > > --- > > lib/client/gnt_cluster.py | 279 > > ++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 279 insertions(+) > > Interdiff due to working in review comments on patch 12. > > diff --git a/lib/client/gnt_cluster.py b/lib/client/gnt_cluster.py > index f31d8d7..5129005 100644 > --- a/lib/client/gnt_cluster.py > +++ b/lib/client/gnt_cluster.py > @@ -1779,8 +1779,8 @@ def UpgradeGanetiCommand(opts, args): > client.SetQueueDrainFlag(True) > > if utils.SimpleRetry([], _getRunning, > - constants.UPGRADE_QUEUE_POLL_INTERVALL, > - constants.UPGRADE_QUEUE_DRAIN_TAIMEOUT): > + constants.UPGRADE_QUEUE_POLL_INTERVAL, > + constants.UPGRADE_QUEUE_DRAIN_TIMEOUT): > ToStderr("Failed to completely empty the queue.") > client = GetClient() > client.SetQueueDrainFlag(False) > > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores -- Jose Antonio Lopes Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
