LGTM, thanks. Sorry for not having spotted them during the review...
Thomas On Mon, Oct 7, 2013 at 4:10 PM, Helga Velroyen <[email protected]> wrote: > This fixes a couple of lint errors that I missed with > the patch "Fix upgrade and downgrade regarding > disk.dev_type". > > Signed-off-by: Helga Velroyen <[email protected]> > --- > tools/cfgupgrade | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/cfgupgrade b/tools/cfgupgrade > index 7141e9b..afd1d70 100755 > --- a/tools/cfgupgrade > +++ b/tools/cfgupgrade > @@ -62,7 +62,7 @@ DOWNGRADE_MINOR = 8 > # (mapping differing old LD_* constants to new DT_* constants) > DEV_TYPE_OLD_NEW = {"lvm": constants.DT_PLAIN, "drbd8": > constants.DT_DRBD8} > # (mapping differing new DT_* constants to old LD_* constants) > -DEV_TYPE_NEW_OLD = {v:k for k,v in DEV_TYPE_OLD_NEW.items()} > +DEV_TYPE_NEW_OLD = dict((v, k) for k, v in DEV_TYPE_OLD_NEW.items()) > > > class Error(Exception): > @@ -387,6 +387,7 @@ def DowngradeDiskDevType(disk): > """Downgrades the disks' device type.""" > ChangeDiskDevType(disk, DEV_TYPE_NEW_OLD) > > + > def DowngradeDisks(disks, owner): > for disk in disks: > # Remove spindles to downgrade to 2.8 > -- > 1.8.4 > > -- Thomas Thrainer | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
