LGTM, thanks.

On Mon, Oct 7, 2013 at 4:37 PM, Jose A. Lopes <[email protected]> wrote:

> Add export version constants to the Haskell to Python constant
> generation.
>
> Signed-off-by: Jose A. Lopes <[email protected]>
> ---
>  lib/constants.py          | 4 ++--
>  src/Ganeti/HsConstants.hs | 6 ++++++
>  2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/lib/constants.py b/lib/constants.py
> index 24c52f4..9bf3dc7 100644
> --- a/lib/constants.py
> +++ b/lib/constants.py
> @@ -37,8 +37,8 @@ OS_API_V15 = _constants.OS_API_V15
>  OS_API_V20 = _constants.OS_API_V20
>  OS_API_VERSIONS = _constants.OS_API_VERSIONS
>  VCS_VERSION = _vcsversion.VCS_VERSION
> -EXPORT_VERSION = 0
> -RAPI_VERSION = 2
> +EXPORT_VERSION = _constants.EXPORT_VERSION
> +RAPI_VERSION = _constants.RAPI_VERSION
>
>  VERSION_MAJOR = _constants.VERSION_MAJOR
>  VERSION_MINOR = _constants.VERSION_MINOR
> diff --git a/src/Ganeti/HsConstants.hs b/src/Ganeti/HsConstants.hs
> index ccb1825..6ff9dbe 100644
> --- a/src/Ganeti/HsConstants.hs
> +++ b/src/Ganeti/HsConstants.hs
> @@ -156,6 +156,12 @@ osApiV20 = 20
>  osApiVersions :: FrozenSet Int
>  osApiVersions = ConstantUtils.mkSet [osApiV10, osApiV15, osApiV20]
>
> +exportVersion :: Int
> +exportVersion = 0
> +
> +rapiVersion :: Int
> +rapiVersion = 2
> +
>  configMajor :: Int
>  configMajor = AutoConf.versionMajor
>
> --
> 1.8.4
>
>


-- 
Thomas Thrainer | Software Engineer | [email protected] |

Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Reply via email to