LGTM, thanks.

On Mon, Oct 7, 2013 at 4:37 PM, Jose A. Lopes <[email protected]> wrote:

> Add 2 more constants to the Haskell to Python constant generation.
>
> Signed-off-by: Jose A. Lopes <[email protected]>
> ---
>  lib/constants.py          | 4 ++--
>  src/Ganeti/HsConstants.hs | 6 ++++++
>  2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/lib/constants.py b/lib/constants.py
> index c53215b..24eca29 100644
> --- a/lib/constants.py
> +++ b/lib/constants.py
> @@ -152,7 +152,7 @@ DAEMONS_EXTRA_LOGFILES = \
>
>  DEV_CONSOLE = _constants.DEV_CONSOLE
>
> -PROC_MOUNTS = "/proc/mounts"
> +PROC_MOUNTS = _constants.PROC_MOUNTS
>
>  LUXI_EOM = _constants.LUXI_EOM
>  LUXI_VERSION = _constants.LUXI_VERSION
> @@ -166,7 +166,7 @@ SYSLOG_YES = _constants.SYSLOG_YES
>  SYSLOG_ONLY = _constants.SYSLOG_ONLY
>  SYSLOG_SOCKET = _constants.SYSLOG_SOCKET
>
> -EXPORT_CONF_FILE = "config.ini"
> +EXPORT_CONF_FILE = _constants.EXPORT_CONF_FILE
>
>  XEN_BOOTLOADER = _constants.XEN_BOOTLOADER
>  XEN_KERNEL = _constants.XEN_KERNEL
> diff --git a/src/Ganeti/HsConstants.hs b/src/Ganeti/HsConstants.hs
> index da99cdd..c1cc885 100644
> --- a/src/Ganeti/HsConstants.hs
> +++ b/src/Ganeti/HsConstants.hs
> @@ -388,6 +388,9 @@ extraLogreasonError = Runtime.daemonsExtraLogbase
> GanetiMond ErrorLog
>  devConsole :: String
>  devConsole = ConstantUtils.devConsole
>
> +procMounts :: String
> +procMounts = "/proc/mounts"
> +
>  -- * Luxi (Local UniX Interface) related constants
>
>  luxiEom :: PythonChar
> @@ -423,6 +426,9 @@ syslogOnly = Logging.syslogUsageToRaw SyslogOnly
>  syslogSocket :: String
>  syslogSocket = "/dev/log"
>
> +exportConfFile :: String
> +exportConfFile = "config.ini"
> +
>  -- * Xen
>
>  xenBootloader :: String
> --
> 1.8.4
>
>


-- 
Thomas Thrainer | Software Engineer | [email protected] |

Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Reply via email to