LGTM, thanks.

On Mon, Oct 7, 2013 at 4:37 PM, Jose A. Lopes <[email protected]> wrote:

> Add import/export config constants to the Haskell to Python constant
> generation.
>
> Signed-off-by: Jose A. Lopes <[email protected]>
> ---
>  lib/constants.py          | 11 +++++------
>  src/Ganeti/HsConstants.hs | 17 +++++++++++++++++
>  2 files changed, 22 insertions(+), 6 deletions(-)
>
> diff --git a/lib/constants.py b/lib/constants.py
> index 33f3827..4baafa8 100644
> --- a/lib/constants.py
> +++ b/lib/constants.py
> @@ -386,12 +386,11 @@ RIE_CONNECT_ATTEMPT_TIMEOUT =
> _constants.RIE_CONNECT_ATTEMPT_TIMEOUT
>  RIE_CONNECT_RETRIES = _constants.RIE_CONNECT_RETRIES
>  CHILD_LINGER_TIMEOUT = _constants.CHILD_LINGER_TIMEOUT
>
> -# import/export config options
> -INISECT_EXP = "export"
> -INISECT_INS = "instance"
> -INISECT_HYP = "hypervisor"
> -INISECT_BEP = "backend"
> -INISECT_OSP = "os"
> +INISECT_EXP = _constants.INISECT_EXP
> +INISECT_INS = _constants.INISECT_INS
> +INISECT_HYP = _constants.INISECT_HYP
> +INISECT_BEP = _constants.INISECT_BEP
> +INISECT_OSP = _constants.INISECT_OSP
>
>  # dynamic device modification
>  DDM_ADD = _constants.DDM_ADD
> diff --git a/src/Ganeti/HsConstants.hs b/src/Ganeti/HsConstants.hs
> index 9c8afdf..6fe04bc 100644
> --- a/src/Ganeti/HsConstants.hs
> +++ b/src/Ganeti/HsConstants.hs
> @@ -990,6 +990,23 @@ rieConnectTimeout = 180
>  childLingerTimeout :: Double
>  childLingerTimeout = 5.0
>
> +-- * Import/export config options
> +
> +inisectBep :: String
> +inisectBep = "backend"
> +
> +inisectExp :: String
> +inisectExp = "export"
> +
> +inisectHyp :: String
> +inisectHyp = "hypervisor"
> +
> +inisectIns :: String
> +inisectIns = "instance"
> +
> +inisectOsp :: String
> +inisectOsp = "os"
> +
>  -- * Dynamic device modification
>
>  ddmAdd :: String
> --
> 1.8.4
>
>


-- 
Thomas Thrainer | Software Engineer | [email protected] |

Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Reply via email to