LGTM, thanks.

On Mon, Oct 7, 2013 at 4:37 PM, Jose A. Lopes <[email protected]> wrote:

> Add 'diskTransferConnectTimeout' constant to the Haskell to Python
> constant generation.
>
> Signed-off-by: Jose A. Lopes <[email protected]>
> ---
>  lib/constants.py          | 4 +---
>  src/Ganeti/HsConstants.hs | 4 ++++
>  2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/lib/constants.py b/lib/constants.py
> index 99ac484..3a250ff 100644
> --- a/lib/constants.py
> +++ b/lib/constants.py
> @@ -442,9 +442,7 @@ MIN_VG_SIZE = _constants.MIN_VG_SIZE
>  DEFAULT_MAC_PREFIX = _constants.DEFAULT_MAC_PREFIX
>  DEFAULT_SHUTDOWN_TIMEOUT = _constants.DEFAULT_SHUTDOWN_TIMEOUT
>  NODE_MAX_CLOCK_SKEW = _constants.NODE_MAX_CLOCK_SKEW
> -# Time for an intra-cluster disk transfer to wait for a connection
> -DISK_TRANSFER_CONNECT_TIMEOUT = 60
> -# Disk index separator
> +DISK_TRANSFER_CONNECT_TIMEOUT = _constants.DISK_TRANSFER_CONNECT_TIMEOUT
>  DISK_SEPARATOR = _constants.DISK_SEPARATOR
>  IP_COMMAND_PATH = _constants.IP_COMMAND_PATH
>
> diff --git a/src/Ganeti/HsConstants.hs b/src/Ganeti/HsConstants.hs
> index f860e04..a7a878b 100644
> --- a/src/Ganeti/HsConstants.hs
> +++ b/src/Ganeti/HsConstants.hs
> @@ -1131,6 +1131,10 @@ defaultShutdownTimeout = 120
>  nodeMaxClockSkew :: Int
>  nodeMaxClockSkew = 150
>
> +-- | Time for an intra-cluster disk transfer to wait for a connection
> +diskTransferConnectTimeout :: Int
> +diskTransferConnectTimeout = 60
> +
>  -- | Disk index separator
>  diskSeparator :: String
>  diskSeparator = AutoConf.diskSeparator
> --
> 1.8.4
>
>


-- 
Thomas Thrainer | Software Engineer | [email protected] |

Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Reply via email to