LGTM, thanks.

On Mon, Oct 7, 2013 at 4:37 PM, Jose A. Lopes <[email protected]> wrote:

> Add reboot behaviour constants to the Haskell to Python constant
> generation.
>
> Signed-off-by: Jose A. Lopes <[email protected]>
> ---
>  lib/constants.py          | 11 +++--------
>  src/Ganeti/HsConstants.hs | 11 +++++++++++
>  2 files changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/lib/constants.py b/lib/constants.py
> index 5f0c05e..6f19f47 100644
> --- a/lib/constants.py
> +++ b/lib/constants.py
> @@ -502,14 +502,9 @@ INSTANCE_REBOOT_HARD = _constants.INSTANCE_REBOOT_HARD
>  INSTANCE_REBOOT_FULL = _constants.INSTANCE_REBOOT_FULL
>  REBOOT_TYPES = _constants.REBOOT_TYPES
>
> -# instance reboot behaviors
> -INSTANCE_REBOOT_ALLOWED = "reboot"
> -INSTANCE_REBOOT_EXIT = "exit"
> -
> -REBOOT_BEHAVIORS = compat.UniqueFrozenset([
> -  INSTANCE_REBOOT_ALLOWED,
> -  INSTANCE_REBOOT_EXIT,
> -  ])
> +INSTANCE_REBOOT_ALLOWED = _constants.INSTANCE_REBOOT_ALLOWED
> +INSTANCE_REBOOT_EXIT = _constants.INSTANCE_REBOOT_EXIT
> +REBOOT_BEHAVIORS = _constants.REBOOT_BEHAVIORS
>
>  VTYPE_STRING = _constants.VTYPE_STRING
>  VTYPE_MAYBE_STRING = _constants.VTYPE_MAYBE_STRING
> diff --git a/src/Ganeti/HsConstants.hs b/src/Ganeti/HsConstants.hs
> index 67e71e0..904faa0 100644
> --- a/src/Ganeti/HsConstants.hs
> +++ b/src/Ganeti/HsConstants.hs
> @@ -1293,6 +1293,17 @@ esScripts =
>  esParametersFile :: String
>  esParametersFile = "parameters.list"
>
> +-- * Instance reboot behaviors
> +
> +instanceRebootAllowed :: String
> +instanceRebootAllowed = "reboot"
> +
> +instanceRebootExit :: String
> +instanceRebootExit = "exit"
> +
> +rebootBehaviors :: [String]
> +rebootBehaviors = [instanceRebootAllowed, instanceRebootExit]
> +
>  -- * VTypes
>
>  vtypeBool :: VType
> --
> 1.8.4
>
>


-- 
Thomas Thrainer | Software Engineer | [email protected] |

Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Reply via email to