LGTM, thanks.

On Mon, Oct 7, 2013 at 4:38 PM, Jose A. Lopes <[email protected]> wrote:

> Add VNC related constants to the Haskell to Python constant generation.
>
> Signed-off-by: Jose A. Lopes <[email protected]>
> ---
>  lib/constants.py          | 5 ++---
>  src/Ganeti/HsConstants.hs | 6 ++++++
>  2 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/lib/constants.py b/lib/constants.py
> index 075ae8f..16ccdbf 100644
> --- a/lib/constants.py
> +++ b/lib/constants.py
> @@ -854,9 +854,8 @@ HT_LXC = _constants.HT_LXC
>  HYPER_TYPES = _constants.HYPER_TYPES
>  HTS_REQ_PORT = _constants.HTS_REQ_PORT
>
> -VNC_BASE_PORT = 5900
> -VNC_DEFAULT_BIND_ADDRESS = IP4_ADDRESS_ANY
> -
> +VNC_BASE_PORT = _constants.VNC_BASE_PORT
> +VNC_DEFAULT_BIND_ADDRESS = _constants.VNC_DEFAULT_BIND_ADDRESS
>  # NIC types
>  HT_NIC_RTL8139 = "rtl8139"
>  HT_NIC_NE2K_PCI = "ne2k_pci"
> diff --git a/src/Ganeti/HsConstants.hs b/src/Ganeti/HsConstants.hs
> index 63a4e75..78abf4f 100644
> --- a/src/Ganeti/HsConstants.hs
> +++ b/src/Ganeti/HsConstants.hs
> @@ -2247,6 +2247,12 @@ hyperTypes = ConstantUtils.mkSet $ map
> Types.hypervisorToRaw [minBound..]
>  htsReqPort :: FrozenSet String
>  htsReqPort = ConstantUtils.mkSet [htXenHvm, htKvm]
>
> +vncBasePort :: Int
> +vncBasePort = 5900
> +
> +vncDefaultBindAddress :: String
> +vncDefaultBindAddress = ip4AddressAny
> +
>  -- * Migration type
>
>  htMigrationLive :: String
> --
> 1.8.4
>
>


-- 
Thomas Thrainer | Software Engineer | [email protected] |

Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Reply via email to