LGTM, thanks.

On Mon, Oct 7, 2013 at 4:38 PM, Jose A. Lopes <[email protected]> wrote:

> Add 'defaultEnabledHypervisor' to the Haskell to Python constant
> generation.
>
> Signed-off-by: Jose A. Lopes <[email protected]>
> ---
>  lib/constants.py          | 3 +--
>  src/Ganeti/HsConstants.hs | 4 ++++
>  2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/lib/constants.py b/lib/constants.py
> index 004ed8a..29a4040 100644
> --- a/lib/constants.py
> +++ b/lib/constants.py
> @@ -1213,8 +1213,7 @@ VALID_SS_HVPARAMS_KEYS =
> _constants.VALID_SS_HVPARAMS_KEYS
>
>  SS_FILE_PERMS = _constants.SS_FILE_PERMS
>
> -# cluster wide default parameters
> -DEFAULT_ENABLED_HYPERVISOR = HT_XEN_PVM
> +DEFAULT_ENABLED_HYPERVISOR = _constants.DEFAULT_ENABLED_HYPERVISOR
>
>  HVC_DEFAULTS = {
>    HT_XEN_PVM: {
> diff --git a/src/Ganeti/HsConstants.hs b/src/Ganeti/HsConstants.hs
> index feff86c..ad495ab 100644
> --- a/src/Ganeti/HsConstants.hs
> +++ b/src/Ganeti/HsConstants.hs
> @@ -3414,6 +3414,10 @@ validSsHvparamsKeys =
>  ssFilePerms :: Int
>  ssFilePerms = 0o444
>
> +-- | Cluster wide default parameters
> +defaultEnabledHypervisor :: String
> +defaultEnabledHypervisor = htXenPvm
> +
>  -- * Confd
>
>  confdProtocolVersion :: Int
> --
> 1.8.4
>
>


-- 
Thomas Thrainer | Software Engineer | [email protected] |

Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Reply via email to