LGTM, thanks.
On Mon, Oct 7, 2013 at 4:38 PM, Jose A. Lopes <[email protected]> wrote: > Add 'maxUdpDataSize' constant to the Haskell to Python constant generation. > > Signed-off-by: Jose A. Lopes <[email protected]> > --- > lib/constants.py | 7 +------ > src/Ganeti/HsConstants.hs | 9 +++++++++ > 2 files changed, 10 insertions(+), 6 deletions(-) > > diff --git a/lib/constants.py b/lib/constants.py > index 59539a3..bb1a373 100644 > --- a/lib/constants.py > +++ b/lib/constants.py > @@ -1477,12 +1477,7 @@ CONFD_DEFAULT_REQ_COVERAGE = > _constants.CONFD_DEFAULT_REQ_COVERAGE > > CONFD_CLIENT_EXPIRE_TIMEOUT = _constants.CONFD_CLIENT_EXPIRE_TIMEOUT > > -# Maximum UDP datagram size. > -# On IPv4: 64K - 20 (ip header size) - 8 (udp header size) = 65507 > -# On IPv6: 64K - 40 (ip6 header size) - 8 (udp header size) = 65487 > -# (assuming we can't use jumbo frames) > -# We just set this to 60K, which should be enough > -MAX_UDP_DATA_SIZE = 61440 > +MAX_UDP_DATA_SIZE = _constants.MAX_UDP_DATA_SIZE > > # User-id pool minimum/maximum acceptable user-ids. > UIDPOOL_UID_MIN = 0 > diff --git a/src/Ganeti/HsConstants.hs b/src/Ganeti/HsConstants.hs > index c823b8d..7a8c776 100644 > --- a/src/Ganeti/HsConstants.hs > +++ b/src/Ganeti/HsConstants.hs > @@ -3614,6 +3614,15 @@ confdDefaultReqCoverage = 6 > confdClientExpireTimeout :: Int > confdClientExpireTimeout = 10 > > +-- | Maximum UDP datagram size. > +-- > +-- On IPv4: 64K - 20 (ip header size) - 8 (udp header size) = 65507 > +-- On IPv6: 64K - 40 (ip6 header size) - 8 (udp header size) = 65487 > +-- (assuming we can't use jumbo frames) > +-- We just set this to 60K, which should be enough > +maxUdpDataSize :: Int > +maxUdpDataSize = 61440 > + > -- * Possible values for NodeGroup.alloc_policy > > allocPolicyLastResort :: String > -- > 1.8.4 > > -- Thomas Thrainer | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
