LGTM, thanks.
On Mon, Oct 7, 2013 at 4:38 PM, Jose A. Lopes <[email protected]> wrote: > Add assorted constants to the Haskell to Python constant generation. > > Signed-off-by: Jose A. Lopes <[email protected]> > --- > lib/constants.py | 6 ++---- > src/Ganeti/HsConstants.hs | 9 +++++++++ > 2 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/lib/constants.py b/lib/constants.py > index 0849fa5..db20968 100644 > --- a/lib/constants.py > +++ b/lib/constants.py > @@ -1482,11 +1482,9 @@ MAX_UDP_DATA_SIZE = _constants.MAX_UDP_DATA_SIZE > UIDPOOL_UID_MIN = _constants.UIDPOOL_UID_MIN > UIDPOOL_UID_MAX = _constants.UIDPOOL_UID_MAX > > -# Name or path of the pgrep command > -PGREP = "pgrep" > +PGREP = _constants.PGREP > > -# Name of the node group that gets created at cluster init or upgrade > -INITIAL_NODE_GROUP_NAME = "default" > +INITIAL_NODE_GROUP_NAME = _constants.INITIAL_NODE_GROUP_NAME > > ALLOC_POLICY_PREFERRED = _constants.ALLOC_POLICY_PREFERRED > ALLOC_POLICY_LAST_RESORT = _constants.ALLOC_POLICY_LAST_RESORT > diff --git a/src/Ganeti/HsConstants.hs b/src/Ganeti/HsConstants.hs > index bed0f42..ca7a729 100644 > --- a/src/Ganeti/HsConstants.hs > +++ b/src/Ganeti/HsConstants.hs > @@ -3633,6 +3633,15 @@ uidpoolUidMin = 0 > uidpoolUidMax :: Integer > uidpoolUidMax = 2 ^ 32 - 1 > > +-- | Name or path of the pgrep command > +pgrep :: String > +pgrep = "pgrep" > + > +-- | Name of the node group that gets created at cluster init or > +-- upgrade > +initialNodeGroupName :: String > +initialNodeGroupName = "default" > + > -- * Possible values for NodeGroup.alloc_policy > > allocPolicyLastResort :: String > -- > 1.8.4 > > -- Thomas Thrainer | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
