On Wed, Dec 11, 2013 at 10:31 AM, Klaus Aehlig <[email protected]> wrote:

> On Tue, Dec 10, 2013 at 05:34:41PM +0100, Petr Pudlak wrote:
> > While at it, generalize also the MonadPlus instance of GenericResult and
> > add some Functor/Applicative instances.
> >
> > Signed-off-by: Petr Pudlak <[email protected]>
> > ---
> >  src/Ganeti/BasicTypes.hs | 53
> +++++++++++++++++++++++++++++++++++++++---------
> >  1 file changed, 43 insertions(+), 10 deletions(-)
>
> LGTM
>
> >  -- | Lift a `Result` value to a `ResultT`.
> >  resultT :: Monad m => GenericResult a b -> ResultT a m b
> >  resultT = ResultT . return
> >
> > +
> >  -- | Simple checker for whether a 'GenericResult' is OK.
> >  isOk :: GenericResult a b -> Bool
> >  isOk (Ok _) = True
>
> Unrelated empty line added here?
>
> It's a mistake, I'll correct it.

Reply via email to