LGTM, Thanks
On Fri, Dec 13, 2013 at 10:43 AM, Klaus Aehlig <[email protected]> wrote: > On Fri, Dec 13, 2013 at 10:18:58AM +0100, Petr Pudlák wrote: > > LGTM, Thanks > > > > (Shouldn't we log nonparsable watcher content as an error? It seems to me > > like it's not something that happens under normal conditions.) > > I think we should go for warning, as the parallel python code > (lib/utils/io.py) > does as well. It is something that should not happen under normal > conditions, > but it has a well-defined semantics and there is a safe option to proceed. > > Interdiff [PATCH master 6/7] Add a predicate for watcher pause > > diff --git a/src/Ganeti/Query/Cluster.hs b/src/Ganeti/Query/Cluster.hs > index c1d2b15..f689cfb 100644 > --- a/src/Ganeti/Query/Cluster.hs > +++ b/src/Ganeti/Query/Cluster.hs > @@ -59,6 +59,6 @@ isWatcherPaused = do > now <- getCurrentTime > return $ if n > now then Just n else Nothing > _ -> do > - logInfo $ "Watcher pause file contents '" ++ s > - ++ "' not parsable as int" > + logWarning $ "Watcher pause file contents '" ++ s > + ++ "' not parsable as int" > return Nothing > > > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores >
