LGTM, thanks


On Wed, Dec 18, 2013 at 3:38 PM, Santi Raffa <[email protected]> wrote:

> Reexport exception classes more explicitly for pylint's convenience.
>
> Signed-off-by: Santi Raffa <[email protected]>
> ---
>  lib/luxi.py | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/lib/luxi.py b/lib/luxi.py
> index c3003da..128c28a 100644
> --- a/lib/luxi.py
> +++ b/lib/luxi.py
> @@ -33,9 +33,7 @@ from ganeti import constants
>  from ganeti import objects
>  import ganeti.rpc.client as cl
>  from ganeti.rpc.transport import Transport
> -from ganeti.rpc.errors import (ProtocolError, ConnectionClosedError,
> -                               TimeoutError, RequestError, NoMasterError,
> -                               PermissionError)
> +import ganeti.rpc.errors
>
>  __all__ = [
>    # functions:
> @@ -76,6 +74,14 @@ REQ_ALL = constants.LUXI_REQ_ALL
>  DEF_RWTO = constants.LUXI_DEF_RWTO
>  WFJC_TIMEOUT = constants.LUXI_WFJC_TIMEOUT
>
> +# "Legacy" re-exports.
> +ProtocolError = ganeti.rpc.errors.ProtocolError
> +ConnectionClosedError = ganeti.rpc.errors.ConnectionClosedError
> +TimeoutError = ganeti.rpc.errors.TimeoutError
> +RequestError = ganeti.rpc.errors.RequestError
> +NoMasterError = ganeti.rpc.errors.NoMasterError
> +PermissionError = ganeti.rpc.errors.PermissionError
> +
>
>  class Client(cl.AbstractClient):
>    """High-level client implementation.
> --
> 1.8.5.1
>
>


-- 
-- 
Helga Velroyen | Software Engineer | [email protected] |

Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Reply via email to