On 13:11 Mon 20 Jan     , Klaus Aehlig wrote:
> > Commit 1c3231aa changed the invocation of _GetNodeRole() to pass the
> > master node by UUID and not by name, but didn't change the
> > implementation to compare the nodes by name. As a result, the master
> > node (which is also a master candidate) would always fall through to the
> > second option and be marked as 'C' instead as 'M'.
> > 
> > We fix this by modifying the implementation of _GetNodeRole() to perform
> > the comparison by UUID and also change the respective tests to test the
> > new API.
> > 
> > Signed-off-by: Apollon Oikonomopoulos <[email protected]>
> > ---
> >  lib/query.py                     |  8 ++++----
> >  test/py/ganeti.query_unittest.py | 23 +++++++++++++----------
> >  2 files changed, 17 insertions(+), 14 deletions(-)
> 
> LGTM

Hi,

Unfortunately this patch doesn't address LuxiD also having the same 
issue. I'm working on a fix, currently building to test if it works.

Regards,
Apollon

Reply via email to