Re: [PATCH stable-2.11 1/2] Add RPC call jobqueue_rename

[Petr Pudlák]

LGTM, thanks.


On Wed, Jan 22, 2014 at 3:00 PM, Klaus Aehlig <aeh...@google.com> wrote:

> Archiving jobs is also replicated to all master candidates.
> Therefore luxid needs to be aware of this RPC call.
>
> Signed-off-by: Klaus Aehlig <aeh...@google.com>
> ---
>  src/Ganeti/Rpc.hs | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/src/Ganeti/Rpc.hs b/src/Ganeti/Rpc.hs
> index 19d1576..598b76f 100644
> --- a/src/Ganeti/Rpc.hs
> +++ b/src/Ganeti/Rpc.hs
> @@ -77,6 +77,7 @@ module Ganeti.Rpc
>    , RpcResultExportList(..)
>
>    , RpcCallJobqueueUpdate(..)
> +  , RpcCallJobqueueRename(..)
>    , RpcCallSetWatcherPause(..)
>    , RpcCallSetDrainFlag(..)
>    ) where
> @@ -605,6 +606,27 @@ instance Rpc RpcCallJobqueueUpdate
> RpcResultJobQueueUpdate where
>        _ -> Left $ JsonDecodeError
>             ("Expected JSNull, got " ++ show (pp_value res))
>
> +-- | Rename a file in the job queue
> +
> +$(buildObject "RpcCallJobqueueRename" "rpcCallJobqueueRename"
> +  [ simpleField "rename" [t| [(String, String)] |]
> +  ])
> +
> +$(buildObject "RpcResultJobqueueRename" "rpcResultJobqueueRename" [])
> +
> +instance RpcCall RpcCallJobqueueRename where
> +  rpcCallName _          = "jobqueue_rename"
> +  rpcCallTimeout _       = rpcTimeoutToRaw Fast
> +  rpcCallAcceptOffline _ = False
> +  rpcCallData _ call     = J.encode [ rpcCallJobqueueRenameRename call ]
> +
> +instance Rpc RpcCallJobqueueRename RpcResultJobqueueRename where
> +  rpcResultFill _ res =
> +    case res of
> +      J.JSNull -> Right RpcResultJobqueueRename
> +      _ -> Left $ JsonDecodeError
> +           ("Expected JSNull, got " ++ show (pp_value res))
> +
>  -- ** Watcher Status Update
>
>  -- | Set the watcher status
> --
> 1.8.5.3
>
>